Skip to content

Fix: allow Enter to trigger search with autocomplete menu open #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix: allow Enter to trigger search with autocomplete menu open #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2bbdab7
chore: publishing to own scope to test
nicholasgriffintn Feb 23, 2024
f117e9a
Merge branch 'alphagov:main' into new-ng-patch
nicholasgriffintn Mar 17, 2024
d1621df
fix: export as esm
nicholasgriffintn May 15, 2024
d8cacba
chore: reverting
nicholasgriffintn May 16, 2024
dad9114
chore: making module interoperable
nicholasgriffintn May 17, 2024
51ae291
fix: check if input is available before attempting to use it
nicholasgriffintn Jun 25, 2024
c048746
chore: updating
nicholasgriffintn Aug 17, 2024
5742f4b
fix: enter triggers search on input with menu opened
ThomasHenryBBC Nov 24, 2025
95788dd
chore: upgrade dependencies
nicholasgriffintn Nov 24, 2025
9b59aab
chore: update tests
nicholasgriffintn Nov 24, 2025
f80b928
chore: apply standard formatting
nicholasgriffintn Nov 24, 2025
cd6c58b
Merge branch 'new-ng-patch' into upgrade-deps
nicholasgriffintn Nov 24, 2025
0299b38
Merge pull request #16 from nicholasgriffintn/upgrade-deps
nicholasgriffintn Nov 24, 2025
3c2ceb0
fix: apply fix to examples
nicholasgriffintn Nov 24, 2025
709e816
Merge branch 'new-ng-patch' into fix-autocomplete-enter-search
nicholasgriffintn Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

push:
branches:
- main
- new-ng-patch

workflow_dispatch:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

push:
branches:
- main
- new-ng-patch

workflow_dispatch:

Expand Down
2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/ajax-source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,8 @@ <h1>Accessible Autocomplete AJAX source example</h1>
var submittedEl = document.querySelector('.submitted')
submittedEl.classList.remove('submitted--hidden')
var params = new URLSearchParams(document.location.search.split('?')[1])
document.querySelector('.submitted__last-location').innerHTML = params.get('last-location')
document.querySelector('.submitted__passport-location').innerHTML = params.get('passport-location')
document.querySelector('.submitted__last-location').textContent = params.get('last-location')
document.querySelector('.submitted__passport-location').textContent = params.get('passport-location')
}
</script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion examples/form-single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ <h1>Accessible Autocomplete single field form example</h1>
var submittedEl = document.querySelector('.submitted')
submittedEl.classList.remove('submitted--hidden')
var params = new URLSearchParams(document.location.search.split('?')[1])
document.querySelector('.submitted__last-location').innerHTML = params.get('last-location')
document.querySelector('.submitted__last-location').textContent = params.get('last-location')
}
</script>
</body>
Expand Down
4 changes: 2 additions & 2 deletions examples/form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,8 @@ <h1>Accessible Autocomplete form example</h1>
var submittedEl = document.querySelector('.submitted')
submittedEl.classList.remove('submitted--hidden')
var params = new URLSearchParams(document.location.search.split('?')[1])
document.querySelector('.submitted__last-location').innerHTML = params.get('last-location')
document.querySelector('.submitted__passport-location').innerHTML = params.get('passport-location')
document.querySelector('.submitted__last-location').textContent = params.get('last-location')
document.querySelector('.submitted__passport-location').textContent = params.get('passport-location')
}
</script>
</body>
Expand Down
Loading