Fix AJAX example handling of query parameters #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for accessible-autocomplete ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
domoscargin
requested changes
Nov 20, 2025
The examples were injecting the query parameters as HTML, which allowed for arbitrary javascript to be ran (for ex. through an `onerror` attribute on an image). As the values in the query parameters only needs displaying, the query parameter is now displayed via text content.
romaricpascal
force-pushed
the
fix-html-injection-ajax-example
branch
from
c72be5b to
0d315a2
Compare
Member
Author
|
@domoscargin Whoops, sorry for missing those. I've updated the PR. Merging is currently blocked by CI not managing to run Chrome, though. Could merge the extra flags I suggested on the issue to unblock this (and other reviews) and log an issue to figure how to remove them further down the line, maybe? |
domoscargin
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was injecting the query parameters as HTML, which allowed for arbitrary javascript to be ran (for ex. through an
onerrorattribute on an image).As the value only needs displaying, the query parameter is now displayed using
textContent, meaning HTML tags are escaped.