Repository navigation
Conversation
|
Hmm seems people have broken edition support with dependencies of dependencies. I'll have to look, as I don't want to force migration to a new MSRV yet. |
|
I did notice the dependency issue in e-g recently but didn't have time to look into it. Let me know if you find a solution or if I need to create a new patch release of e-g 0.8 that fixes the |
yeah i think that'd help, i'm a bit short on time atm. but will try to get back to this end of week |
|
I've created a new branch for the maintenance release of e-g 0.8 to fix the dependency issue. Can you try by temporarily using a GIT dependency before I publish 0.8.2? |
I'm guessing latest e-g master is not compatible with mipidsi? I don't have time to look into this atm. will check back later. |
|
I think the error is caused by the |
That fixed most but somehow not all, I'll try to look into this more later this weekend/early next week. |
|
The examples have their own Cargo.toml and still depend on the crates.io version of I've created a PR for the dependency fix, but apparently it still needs some work because CI is unhappy. |
|
@rfuest so this passes CI with your ref everywhere now. I think I'll see if we can refactor things into a workspace so we keep all dependencies in one cargo.toml file while you sort out the e-g release. |
|
Can you try it again with the latest commit rfuest/embedded-graphics@77372e4?
I believe we intentionally left the examples separate because they use different target architectures. |
|
e-g-core 0.4.1 and e-g 0.8.2 are now released. |
8237a5e to
8bdbb78
Compare
|
@rfuest should be good now |
rfuest
left a comment
There was a problem hiding this comment.
LGTM, I'm glad the dependency weirdness is fixed, because it was a bit of a pain to get it working in e-g.
If you want you could add the missing dates in the changelog for 0.9 and 0.10 before the release, but it's not a release blocker IMO.
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [v0.10.0] |
There was a problem hiding this comment.
The entries before 0.9.0 contain the release date, should we also include the date for 0.9 and 0.10?
@rfuest lmk if I missed something, once we merge I'll push to crates.io
Solves #193