Skip to content

Feature/ecom 2591 php client rebuild the client in service #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

webaaz
Copy link
Contributor

@webaaz webaaz commented May 7, 2025

Reason for change

Linear task

Code changes

Done:

  • Invert dependencies
  • Fix Client role
  • Move to PHP 7.4
  • Add exceptions
  • Fix unit tests
  • Linting

TODO:

  • Tests

How to test

Launch unit tests: task 8.3:tests

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Done:
- Invert dependencies
- Fix Client role
- Move to PHP 7.4
- Add exceptions
- Fix unit tests
- Linting

TODO:
- Tests
@webaaz webaaz changed the base branch from main to develop May 7, 2025 15:51
refactor tests / add tests
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Critical Issues (required ≤ 0)
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant