Skip to content

Improving examples #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improving examples #1

wants to merge 1 commit into from

Conversation

paveltovchigrechko
Copy link
Contributor

Changes:

  • add dependencies for pyproject.toml
  • add --alluredir as Pytest option
  • remove unused allure import
  • change fixture example

@@ -14,7 +14,20 @@ classifiers = [
]
dependencies = [
# Put the project's production dependencies here:

"allure-pytest==2.13.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only production dependencies should go here (of which we have none).

Currently, Python has no standard way to define development dependencies. This concept is tool-specific.

This repo uses the requirements file (this is the best option when using raw pip IMO). So, we should leave the dev deps in the requirement file instead of putting them in pyproject.toml.

This discussion covers dev dependencies in great detail.


addopts = [
"--alluredir", "allure-results",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Let's remove these arguments from run scripts then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants