fix: fallback to rosetta for versions under natively compilable v0.8.5 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
added a commit
to gakonst/ethers-rs
that referenced
this pull request
Mar 13, 2022
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Mar 13, 2022
Bumps SVM making Solidity compiler fall back to Rosetta for versions before 0.8.5 ref: alloy-rs/svm-rs#29 ethereum/solidity#12784
jsLover1117
added a commit
to jsLover1117/ethers-rs
that referenced
this pull request
Jul 17, 2022
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
Bumps SVM making Solidity compiler fall back to Rosetta for versions before 0.8.5 ref: alloy-rs/svm-rs#29 ethereum/solidity#12784
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
Bumps SVM making Solidity compiler fall back to Rosetta for versions before 0.8.5 ref: alloy-rs/svm-rs#29 ethereum/solidity#12784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: ethereum/solidity#12784
This is a temporary fix to allow support for all
solcversions for MacOS users. If thesolcversion in question is>= 0.8.5(which have been natively compiled and hosted insolc-builds) then we use those. For all other versions under0.8.5we fallback tomacos-amd64builds that require Rosetta support.We expect to eventually fix the compilation issues in the above mentioned GH issue, but for now this is the most reasonable solution to support as many versions as possible via
Foundry