feat: Introduced Initializers to trace inspector

[developeruche]

Close #132

Solution

Introduced an InspectorInitializer which can init both cloneable and non-cloneable inspectors

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[mattsse]

nice, this looks great,

but after further evaluating this, we actually need this to be fallible.

the main use case for this is is so we can use new Inspectors that are not Clone that we need to reinitialize per tx, specifically:

https://github.com/paradigmxyz/revm-inspectors/blob/eb6ed5965050e8723ccf1ec02b0b53f7f0005af5/src/tracing/js/mod.rs#L56-L57

but creating this one is fallible:

https://github.com/paradigmxyz/revm-inspectors/blob/eb6ed5965050e8723ccf1ec02b0b53f7f0005af5/src/tracing/js/mod.rs#L109-L109

so we actually need the initalizer to also return a Result

and then the trace fn would also need to be fallible and we likely need a new error type for

-> Result<TraceOutput<E::HaltReason, E::Inspector>, E::Error>

or use either::Either<E::Error, Init::Error>

wdyt @klkvr

[developeruche]

nice, this looks great,

but after further evaluating this, we actually need this to be fallible.

the main use case for this is is so we can use new Inspectors that are not Clone that we need to reinitialize per tx, specifically:

https://github.com/paradigmxyz/revm-inspectors/blob/eb6ed5965050e8723ccf1ec02b0b53f7f0005af5/src/tracing/js/mod.rs#L56-L57

but creating this one is fallible:

https://github.com/paradigmxyz/revm-inspectors/blob/eb6ed5965050e8723ccf1ec02b0b53f7f0005af5/src/tracing/js/mod.rs#L109-L109

so we actually need the initalizer to also return a Result

and then the trace fn would also need to be fallible and we likely need a new error type for

-> Result<TraceOutput<E::HaltReason, E::Inspector>, E::Error>

or use either::Either<E::Error, Init::Error>

wdyt @klkvr

If I get you right;

pub trait InspectorInitializer<T> {
    /// Create a new inspector instance.
    fn initialize(&mut self) -> T;
}

Initialize should return a result rather than the plain inspector?

[mattsse]

Initialize should return a result rather than the plain inspector?

yep, for example if initializer is || JsInpesctor::new()

[developeruche]

Initialize should return a result rather than the plain inspector?

yep, for example if initializer is || JsInpesctor::new()

Understood, this has been impl

[klkvr]

Suggested change

	<E as Evm>::Inspector,
	<E as Evm>::Error,
	E::Inspector,
	E::Error,

[developeruche]

I couldn't let this go. I needed to specify the associated type before I could proceed with compilation