Skip to content

fix for cairo to render to EPS / PDF #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for cairo to render to EPS / PDF #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/scala/org/allenai/pdffigures2/FigureExtractorBatchCli.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ object FigureExtractorBatchCli extends Logging {
)
val savedFigures = FigureRenderer
.saveFiguresAsImagesCairo(
doc,
inputFile,
filenames.zip(document.figures),
config.figureFormat,
config.dpi
Expand Down Expand Up @@ -228,7 +228,7 @@ object FigureExtractorBatchCli extends Logging {
)
val savedFigures = FigureRenderer
.saveFiguresAsImagesCairo(
doc,
inputFile,
filenames.zip(figuresWithErrors.figures),
config.figureFormat,
config.dpi
Expand Down
10 changes: 4 additions & 6 deletions src/main/scala/org/allenai/pdffigures2/FigureRenderer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ object FigureRenderer {

/** Save figures to disk in a vector graphic format by shelling out to pdftocairo */
def saveFiguresAsImagesCairo(
doc: PDDocument,
inputFile: File,
figuresAndFilenames: Seq[(String, Figure)],
format: String,
dpi: Int
Expand All @@ -161,8 +161,6 @@ object FigureRenderer {
val groupedByPage = figuresAndFilenames.groupBy(_._2.page)
groupedByPage.flatMap {
case (pageNum, pageFigures) =>
val pageDoc = new PDDocument() // Save some IO by just sending cairo the relevant page
pageDoc.addPage(doc.getPage(pageNum))
val savedFigures = pageFigures.map {
case (filename, fig) =>
if (Thread.interrupted()) throw new InterruptedException()
Expand All @@ -171,17 +169,17 @@ object FigureRenderer {
val y = Math.round(box.y1) - PadUnexpandedImage
val w = Math.round(box.width) + PadUnexpandedImage * 2
val h = Math.round(box.height) + PadUnexpandedImage * 2
val pdffn = inputFile.getAbsolutePath
val pdfpg = pageNum + 1
val cmdStr = s"pdftocairo -$format -r $dpi " +
s"-x $x -y $y -H $h -W $w -paperw $w -paperh $h - $filename"
s"-x $x -y $y -H $h -W $w -l $pdfpg -f $pdfpg $pdffn $filename"
val cmd = Runtime.getRuntime.exec(cmdStr)
val outStream = cmd.getOutputStream
pageDoc.save(outStream) // Stream the doc to cairo
if (cmd.waitFor() != 0) {
throw new IOException("Error using cairo to save a figure")
}
SavedFigure(fig, filename, dpi)
}
pageDoc.close()
savedFigures
}
}
Expand Down