-
Notifications
You must be signed in to change notification settings - Fork 458
Adds DPO and SFT to CI and combines push-image with beaker-experiment
#1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| echo "trigger_info=Scheduled run" >> $GITHUB_OUTPUT | ||
| fi | ||
| - name: Get changed files using git diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Workflow Triggers: Incomplete Event Data
The trigger_info output is not set for merge_group events, but the workflow triggers on merge_group. The step only handles push and workflow_dispatch events, leaving trigger_info undefined when triggered by merge groups, which results in an empty trigger description in the summary.
Ran manually: https://github.com/allenai/open-instruct/actions/runs/19119030962
Note
Builds and verifies an integration image, launches GRPO always plus DPO/SFT experiments conditionally, waits in parallel, then pushes the image to Beaker; removes old push workflow/action and adds DPO/SFT test scripts.
.github/workflows/beaker-experiment.yml):grpoalways;dpo/sftwhen relevant files change).open_instruct_auto) to Beaker.3.12, Beaker workspaceai2/open-instruct-dev../.github/workflows/push-image.ymland./.github/actions/push/action.yaml..github/actions/setup/action.yaml) toai2/open-instruct-dev.scripts/train/debug/dpo_integration_test.shandscripts/train/debug/sft_integration_test.shfor CI experiment launches.Written by Cursor Bugbot for commit edd6ac2. This will update automatically on new commits. Configure here.