refactor: Change three to a peer dependency#406
Merged
Conversation
frasercl
approved these changes
May 18, 2026
Collaborator
There was a problem hiding this comment.
Left and then deleted a comment thinking this was TFE, about how I'd discovered that my understanding of peerDependencies was wrong and that library code needed to peer-depend on packages that provided members of its public interface rather than downstream client packages. You were clearly one step ahead of me here.
I was thrown off by the fact that vole-app currently peer-depends on three which it shouldn't have to do... but it shouldn't have to depend on three at all after #405 merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I ran into a bug in TFE where 3D views would fail, but only in built files. I eventually traced this to changes made in #395, and discovered that it was caused by having conflicting versions of three installed in TFE vs.
vole-core.Changing
threeto a peer dependency invole-corewould help prevent this in the future, so that client libraries only have one version ofthreeinstalled.Couple questions:
threewe support, in case there are breaking changes on a minor version in the future?