update vole-app and demo uses bioio#26
Conversation
toloudis
requested review from
ShrimpCryptid and
interim17
and removed request for
a team
| During development it may sometimes be useful to do some manual cleanup: | ||
|
|
||
| ```bash | ||
| rm -rf node_modules | ||
| rm -rf yarn.lock | ||
| jlpm install | ||
| jlpm build | ||
| ``` |
There was a problem hiding this comment.
I can think of some other repos that could use this
| # mn = min(0, resized_channel.min()) | ||
| # mx = resized_channel.max() | ||
| # resized_channel = 255.0 * (resized_channel - mn) / (mx - mn) | ||
|
|
||
| # resized_channel = resized_channel.astype(numpy.uint8) |
There was a problem hiding this comment.
yeah I suppose we can just delete it
ShrimpCryptid
left a comment
ShrimpCryptid
left a comment
There was a problem hiding this comment.
LGTM, left a few questions!
| <ViewerStateProvider> | ||
| <ImageViewerApp {...viewerProps} /> | ||
| </ViewerStateProvider> |
There was a problem hiding this comment.
Did we document in Vol-E app that ViewerStateProvider is required?
There was a problem hiding this comment.
Could we make an issue ticket in Vol-E to throw an error message when ViewerStateProvider is not provided?
There was a problem hiding this comment.
I think a wrapper component that automatically includes the ViewerStateProvider would make this nice and clean for clients to integrate as a single component. It could just forward props through to the child.
| cellId: '', | ||
| imageUrl: '', | ||
| parentImageUrl: '', | ||
| visibleControls: { |
There was a problem hiding this comment.
This got changed from showControls to visibleControls, is that correct?
4 participants
update vole-app
update some deps
make sure things build
remove the dtype to uint8 conversion
test demo.ipynb for functionality