feat: Added warnings for potentially unreachable 3D files (3D paths pt. 1)#100
Merged
Conversation
ShrimpCryptid
commented
Nov 20, 2025
Comment on lines
+797
to
+799
| logging.error( | ||
| f"{name} must be a relative path inside the dataset directory or an HTTP(S) URL. Received: '{source}'" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
ex: "F:/data/data.zarr" is not a loadable path for TFE.
Future changes in this data conversion package will likely try and replace/update this path upstream of this final validation step!
ShrimpCryptid
force-pushed
the
fix/writer-warn-3d-paths
branch
from
2375367 to
15af659
Compare
ShrimpCryptid
requested review from
meganrm and
toloudis
and removed request for
a team
toloudis
approved these changes
Nov 21, 2025
meganrm
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Addresses a bug reported by Max Hess, where 3D frame data was failing to load. The reason why was because he was using an absolute path to a different directory (e.g.
C:/my-data/data.zarr), which is not a loadable address.This change adds warning messages for when addresses are potentially unreachable, and is part 1 of a series of changes I'm making to validate source files.
Estimated review size: tiny, 5 minutes
Solution
writer.pywill warn users about potentially unreachable 3D frame data.Type of change