Skip to content

Update antd to v4#88

Draft
schoinh wants to merge 1 commit into
mainfrom
update-antd
Draft

Update antd to v4#88
schoinh wants to merge 1 commit into
mainfrom
update-antd

Conversation

@schoinh
Copy link
Copy Markdown
Contributor

@schoinh schoinh commented Feb 1, 2022

⚠️ This is not ready yet. Looks like we need to update antd to v4 in website-3d-cell-viewer first because it has these issues:

  • After buttons are clicked, borders become really thick

    image

  • Collapsible sections in the left panel don't collapse

  • Collapsible bottom panel behavior and some styling is broken

Problem

Partially resolves: Update Antd to v4 in CFE and website-3d-cell-viewer

Solution

Update antd to v4.18.5 (latest) and fix issues caused by breaking changes in antd

Type of change

Please delete options that are not relevant.

  • Code maintenance (site functionality should remain the same)

Change summary:

  • Tidy, well formulated commit message
  • Another great commit message
  • Something else I/we did

Steps to Verify:

  1. A setup step / beginning state
  2. What to do next
  3. Any other instructions
  4. Expected behavior
  5. Suggestions for testing

Screenshots (optional):

Show-n-tell images/animations here

Keyfiles (delete if not relevant):

  1. main file/entry point
  2. other important file

Thanks for contributing!

@toloudis
Copy link
Copy Markdown
Contributor

TODO: merge w/main, resolve conflicts, upgrade to ant 5, update w3cv version

@ShrimpCryptid ShrimpCryptid linked an issue May 30, 2024 that may be closed by this pull request
53 tasks
@ShrimpCryptid ShrimpCryptid removed a link to an issue May 30, 2024
53 tasks
@toloudis
Copy link
Copy Markdown
Contributor

@meganrm @frasercl @ShrimpCryptid Can we just close this? I think the intent of this PR is already completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants