Feature/release1.10cleanup#367
Open
toloudis wants to merge 7 commits into
Open
Conversation
toloudis
requested review from
frasercl and
meganrm
and removed request for
a team
meganrm
reviewed
May 26, 2026
| maxu16Slider->setSingleStep(1); | ||
| maxu16Slider->setValue(m_gradientData->m_maxu16); | ||
| section0Layout->addRow("Max u16", maxu16Slider); | ||
| Controls::addFormRow(section0Layout, "Max u16", maxu16Slider, tr("Set maximum u16 value"), tr("Maximum u16 value")); |
There was a problem hiding this comment.
are these use facing messages? if so "Set maximum u16 value" seems opaque
Contributor
Author
There was a problem hiding this comment.
yep, good point. Will fix.
meganrm
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of simple cleanup changes. Most of the diffs are just changing the way tooltip strings are passed to controls, which covers a lot of lines.