give a way to access the stale cache #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested changes
Apr 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 90.08% 91.17% +1.09%
==========================================
Files 15 15
Lines 716 714 -2
==========================================
+ Hits 645 651 +6
+ Misses 61 55 -6
+ Partials 10 8 -2
Continue to review full report at Codecov.
|
siennathesane
requested changes
Apr 1, 2020
siennathesane
approved these changes
Apr 2, 2020
siennathesane
previously approved these changes
Apr 2, 2020
|
@cristaloleg this looks good to me. I think it would be good to version bump after merging this because it sets an explicit value, so it's technically a minor API change. @flisky can you please rebase and then re-request a review? |
EntryStatus back to the caller "Expired" cannot be differentiated. Fixing this by default "_" to 0 and incremental RemoveReasons comment was missing for GetWithInfo api so updated that test: ran all unit test cases Change-Id: Ic3e2259630668af0d4b5110125f2d8e43b83081b
flisky
force-pushed
the
master
branch
2 times, most recently
from
c47ca6f to
3da1e57
Compare
cristaloleg
approved these changes
May 7, 2020
siennathesane
approved these changes
May 7, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an update for #181 :)