Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pr 요청 시 테스트 실행하는 스크립트 작성 #8

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

3Juhwan
Copy link
Member

@3Juhwan 3Juhwan commented Jan 21, 2025

작업 내용

ci 스크립트를 작성했어요. 이전에 pr 요청에서 테스트 실행이 없어서 잘못된 커밋을 머지하는 일이 있었어요. 재방 방지를 위해 ci를 도입했어요.

ci 스크립트 작업 내용

  • main 브랜치에 pr 요청시 스크립트가 트리거돼요.
  • 현재 작업은 빌드 -> 테스트 -> 테스트 결과를 코멘트에 작성 으로 구성되어 있어요.

고민 지점과 리뷰 포인트

@3Juhwan 3Juhwan requested a review from boyekim January 21, 2025 06:34
@3Juhwan 3Juhwan self-assigned this Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Test Results

5 tests   5 ✅  1s ⏱️
4 suites  0 💤
4 files    0 ❌

Results for commit 9a9d53c.

♻️ This comment has been updated with latest results.

Copy link
Member

@boyekim boyekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짱멋져요
코멘트까쥐 날리다니🐥🐥

@boyekim boyekim merged commit 759ef04 into main Jan 21, 2025
3 checks passed
@3Juhwan 3Juhwan deleted the ci-template branch January 29, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants