Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noTicket][risk=no]Rename cron job check free tier billing usage #8569

Merged
merged 2 commits into from
May 28, 2024

Conversation

NehaBroad
Copy link
Collaborator

@NehaBroad NehaBroad commented May 15, 2024


PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@jmthibault79
Copy link
Collaborator

Looks good - but there is also a script in api/tools/src/cron. Is there a PR to update the alerts as well?

Copy link
Collaborator

@yonghaoy yonghaoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NehaBroad
Copy link
Collaborator Author

@yonghaoy:
PR to make changes for terra form all-of-us/workbench-terraform-modules#58
That PR will be pushed once this is release

@NehaBroad NehaBroad merged commit effeff1 into main May 28, 2024
21 checks passed
@NehaBroad NehaBroad deleted the nsaxena/renameCronjob branch May 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants