[image] Remove static keyword from isSupported and getSupportedExtensions
#1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simogasp
previously requested changes
May 21, 2025
cbentejac
force-pushed
the
dev/removeStatic
branch
2 times, most recently
from
3ed6429 to
e4c93f4
Compare
cbentejac
approved these changes
May 26, 2025
cbentejac
force-pushed
the
dev/removeStatic
branch
from
e4c93f4 to
e46b5bf
Compare
cbentejac
changed the title
static keyword from isSupported and getSupportedExtensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1863
static std::map<std::string, std::vector<std::string>> extensionList = oiio::get_extension_map();static ->
oiio::get_extension_map()is only called once and as such, extensionList is not reset at each function call. Thus the following code is appending again and again the dots. I don't think static is useful.