Skip to content

[image] Remove static keyword from isSupported and getSupportedExtensions #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

servantftransperfect
Copy link
Contributor

See #1863

static std::map<std::string, std::vector<std::string>> extensionList = oiio::get_extension_map();

static -> oiio::get_extension_map() is only called once and as such, extensionList is not reset at each function call. Thus the following code is appending again and again the dots. I don't think static is useful.

@cbentejac cbentejac force-pushed the dev/removeStatic branch 2 times, most recently from 3ed6429 to e4c93f4 Compare May 26, 2025 15:34
@cbentejac cbentejac added this to the 3.3.0 milestone May 26, 2025
@cbentejac cbentejac linked an issue May 26, 2025 that may be closed by this pull request
@cbentejac cbentejac dismissed simogasp’s stale review May 27, 2025 11:35

Applied suggested changes

@cbentejac cbentejac changed the title Remove static keyword to isSupported and getSupportedExtensions [image] Remove static keyword from isSupported and getSupportedExtensions May 27, 2025
@cbentejac cbentejac merged commit 07e4add into develop May 27, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/removeStatic branch May 27, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] List of supported image formats
3 participants