Redevelop module for TF 0.12 and multiple users #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmori
changed the title
|
Also let me know if the module should still support one single user creation for maximum flexibility in case the configuration with the maps is more complex |
xiaozhu36
requested changes
Aug 24, 2020
| ################################ | ||
| # RAM user | ||
| ################################ | ||
| variable "create" { |
There was a problem hiding this comment.
I think the create should be kept and it can used to control whether create users.
There was a problem hiding this comment.
if the user does not want to create users, commenting the variable "users" will control whether to create users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have redeveloped the module to take advantage of the 0.12 sintax.
The major benefit is to declare multiple users in a module rather than calling the module each time a new user must be created.
It does also print the secret keys for users who use terraform with a different state than local.