feat(pages): add Dockerfile for server hosting - #878
Conversation
|
🔍 OpenCodeReview found 4 issue(s) in this PR.
|
|
The current container is not pushed, because of I have read-only permissions, anyone with write access can push this to ghcr with a valid token (minimal scope: repo:all & packages:write) |
|
Hi @wu21-web, thanks for putting this together! The Dockerfile and nginx setup look solid — nice multi-stage build and sensible caching strategy. That said, our pages site is currently hosted on GitHub Pages, which already handles building, serving, CDN, and HTTPS for us out of the box. We don't have a self-hosting use case at the moment, so adding a Docker layer would introduce extra maintenance overhead (keeping the Dockerfile, nginx config, and lockfile in sync) without a clear benefit right now. If we ever move toward self-hosting or need something GitHub Pages can't provide, we'd love to revisit this. For now though, I'm going to close this one. Thanks again for the contribution! |
Description
Added a docker container for the pages server, making server starts fast because new it is prebuilt.
Type of Change
How Has This Been Tested?
make testpasses locallyLocal Dockerfile build on my mac works (colima+docker) fine, and also added a check-container step with
ubuntu-latestrunner to check the container.Checklist
go fmt,go vet)I think this is not needed for documentation because no customer would ever host a open-code-review pages server themselves
Related Issues
none yet