Skip to content

fix: make FileFilter patterns case-insensitive #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhengfeng101 merged 2 commits into from
Aug 13, 2026
+17 −4
Merged

fix: make FileFilter patterns case-insensitive #859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
385ca59
fix: make file filter patterns case-insensitive
Itachi7011 Aug 12, 2026
49fca1d
test: strengthen case-insensitive file filter coverage
Itachi7011 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/config/rules/system_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func (f *FileFilter) IsUserExcluded(path string) bool {
for _, pattern := range f.Exclude {
expanded := expandBraces(pattern)
for _, p := range expanded {
if matched, _ := doublestar.Match(p, lowerPath); matched {
if matched, _ := doublestar.Match(strings.ToLower(p), lowerPath); matched {
return true
}
}
Expand All @@ -242,7 +242,7 @@ func (f *FileFilter) IsUserIncluded(path string) bool {
for _, pattern := range f.Include {
expanded := expandBraces(pattern)
for _, p := range expanded {
if matched, _ := doublestar.Match(p, lowerPath); matched {
if matched, _ := doublestar.Match(strings.ToLower(p), lowerPath); matched {
return true
}
}
Expand Down
12 changes: 10 additions & 2 deletions internal/config/rules/system_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,8 @@ func TestFileFilter_IsUserIncluded_EmptyInclude(t *testing.T) {

func TestFileFilter_CaseInsensitive(t *testing.T) {
f := &FileFilter{
Include: []string{"src/**/*.java"},
Exclude: []string{"**/generated/**"},
Include: []string{"src/**/*.java", "**/CHANGELOG.md"},
Exclude: []string{"**/generated/**", "README.md"},
}

if !f.IsUserIncluded("SRC/Main/Foo.Java") {
Expand All @@ -687,6 +687,14 @@ func TestFileFilter_CaseInsensitive(t *testing.T) {
if !f.IsUserExcluded("SRC/Generated/Api.java") {
t.Errorf("expected case-insensitive exclude match")
}

// Verify patterns containing uppercase letters also match.
if !f.IsUserIncluded("docs/changelog.md") {
t.Errorf("expected uppercase include pattern to match case-insensitively")
}
if !f.IsUserExcluded("readme.md") {
t.Errorf("expected uppercase exclude pattern to match case-insensitively")
}
}

func TestNewResolver_FileFilterMerged(t *testing.T) {
Expand Down
Loading