fix(provider_tui): Inefficient string concatenation in call to WriteString

[wu21-web]

Description

https://go.dev/gopls/analyzers#writestring-detect-inefficient-string-concatenation-in-uses-of-writestring

fixes inefficient string concatenation in calls to WriteString, enhances performance

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Refactoring (no functional changes)
• Documentation update
• CI / Build / Tooling

How Has This Been Tested?

• make test passes locally
• Manual testing (describe below)
  go test & make build

Checklist

• My code follows the project's coding style (go fmt, go vet)
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or my feature works
• New and existing unit tests pass locally with my changes
• I have updated the documentation accordingly (if applicable)
• I have signed the CLA

Related Issues

none yet

[github-actions]

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

[lizhengfeng101]

Thanks for the contribution! The gopls writestring analyzer suggestion is valid in principle, but in this case the affected code paths (TUI rendering functions called once per frame, and a small loop over diffs) don't benefit meaningfully from eliminating these small string concatenations — the performance difference is unmeasurable in practice.

The tradeoff here is that splitting single-line render expressions into 2-3 separate WriteString calls reduces readability of the TUI code, where seeing the full output structure on one line (prefix + content + newline) is valuable for maintainability.

We'll pass on this one, but appreciate you looking into code quality improvements. If you spot inefficient patterns in hot paths (e.g., tight loops processing large data), those would be great candidates for optimization PRs.