Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
go build -ldflags "${LD_FLAGS}" -o "${BIN_NAME}" ./cmd/opencodereview
echo "bin_name=${BIN_NAME}" >> $GITHUB_ENV

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v7
with:
name: binary-${{ matrix.goos }}-${{ matrix.goarch }}
path: ${{ env.bin_name }}
Comment on lines +55 to 58

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[other · medium]
Version inconsistency: upload-artifact is being upgraded to v7, but download-artifact is being upgraded to v8. While these actions may have independent versioning, this mismatch could indicate:

  1. An accidental version typo (should both be v7 or both be v8?)
  2. Potential compatibility issues between different major versions

Recommendation: Verify that upload-artifact@v7 and download-artifact@v8 are compatible with each other, or consider using matching versions (e.g., both v7 or both v8) to ensure artifacts uploaded by one can be reliably downloaded by the other.

Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
echo "RELEASE_NOTES_EOF"
} >> "$GITHUB_OUTPUT"

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v8
with:
pattern: binary-*
merge-multiple: true
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
- name: Install jq
run: apt-get update && apt-get install -y jq

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v8
with:
pattern: binary-*
merge-multiple: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/translation-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
image: node:24.18.0
steps:
# fetch-depth: 0 so the non-blocking docs check can diff base...head.
- uses: actions/checkout@v4
- uses: actions/checkout@v7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[other · high]
Potentially invalid action version: Jumping from actions/checkout@v4 to @v7 skips two major versions (v5, v6). GitHub's first-party actions typically increment one major version at a time. Please verify that v7 is an actual released version of actions/checkout — if this tag doesn't exist, the workflow will fail at runtime with a "Unable to resolve action" error.

Similarly, the other changed files bump actions/upload-artifact to @v7 and actions/download-artifact to @v8. Please double-check that all target versions exist and review their respective changelogs for breaking changes (e.g., removed/renamed inputs, changed default behaviors).

with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ runs:

- name: Upload review artifacts
if: ${{ always() && inputs.upload_artifacts == 'true' }}
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: ocr-review-result-${{ github.run_id }}-${{ github.run_attempt }}
path: |
Expand Down