feat(viewer): collapse secondary session sections - #738
Merged
lizhengfeng101 merged 2 commits intoAug 6, 2026
Conversation
|
|
Contributor
|
🔍 OpenCodeReview found 6 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep review findings prominent by collapsing the three secondary session details by default:
The Viewer uses native
detailselements and the existing disclosure styling, so each section remains keyboard-accessible and can be expanded without JavaScript. Review Comments and their file groups remain open. Count badges keep the hidden scope visible at a glance, and the token table is placed in an overflow-safe body for narrow screens.Type of Change
How Has This Been Tested?
go vet ./...The regression test verifies all three secondary sections render closed while Review Comment file groups remain open. Browser checks confirmed the sections stay closed at 1265px and 390px widths and expand normally when activated.
go test ./internal/vieweralso reaches three existing permission-mode assertions that are not portable to Windows (TestHandleRepos_PermissionDenied,TestDiscoverRepos_SkipsUnreadableSubdir, andTestListSessions_SkipsUnreadableFiles). The focused Viewer rendering tests pass.Checklist
go fmt,go vet)Related Issues
Closes #734