ci(pages): run tests in Pages workflow - #731
Merged
Merged
Conversation
Signed-off-by: Aryan Singh K. <70511529+aryansk@users.noreply.github.com>
|
|
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
lizhengfeng101
marked this pull request as ready for review
August 5, 2026 09:40
Contributor
Author
|
Thanks for the LGTM and for taking the time to review and merge this. I am glad the CI change fit the project and that the validation was useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
npm teststep to the Pages CI workflow.The workflow already installs dependencies, lints, typechecks, builds, and checks bundle size, but it did not run the existing Vitest suite. This step runs the Pages tests after lint and before typecheck/build so regressions such as critical-CSS drift and ErrorBoundary failures are covered in CI.
Closes #730
Validation
From
pages/:npm test— 4 test files, 16 tests passednpm run lint— passed with 2 pre-existing hook-dependency warningsnpm run typecheck— passednpm run build— passed with existing webpack asset-size warningsnpm run size— passed (86.67 kB Brotli against a 150 kB limit)git diff --check— passedThe commit includes a
Signed-off-byline; the local SSH signing agent was unavailable in this checkout.