improve(pages): simplify ErrorBoundary reload UX and add unit tests - #565
Merged
lizhengfeng101 merged 1 commit intoJul 29, 2026
Merged
Conversation
Closes alibaba#544 - Change RouteErrorFallback reload to call window.location.reload() directly after clearing the session guard - Add vitest + @testing-library/react + jsdom test infrastructure for pages/ - Add ErrorBoundary.test.tsx covering 4 scenarios (chunk error reload, guard prevents double reload, non-chunk error shows fallback, reset clears guard and reloads)
|
|
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the
ErrorBoundaryreload UX: replace the indirect reset-and-catch reload cycle with a directwindow.location.reload()after clearing the session guard. Scoped to theRouteErrorFallbackReload button (verifiedreset()is not called elsewhere --HeroSectionuses a static fallback). Also adds the first unit-test coverage forErrorBoundary(4 scenarios) by introducing vitest + @testing-library/react + jsdom forpages/.Type of Change
How Has This Been Tested?
make testpasses locallynpm run typecheck,npm run lint(0 errors; 2 pre-existing warnings in HeroSection/MarkdownRenderer, unrelated),npm run build,npm run size(82.15 kB < 150 kB) all pass frompages/.npm run test(vitest) -- 4/4 tests pass.Checklist
go fmt,go vet) (pages/ uses eslint;npm run lintpasses)Related Issues
Closes #544