ci(pages): add ESLint and bundle size check to CI pipeline - #558
Merged
Conversation
- Add ESLint with typescript-eslint and react-hooks plugin
- Add size-limit to monitor initial bundle size (150 kB threshold)
- Rename .js configs to .cjs for ESM compatibility ("type": "module")
- Fix no-useless-escape and no-useless-assignment lint errors
- Update pages-ci.yml with lint and size check steps
Contributor
|
🔍 OpenCodeReview found 3 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-eslintrecommended rules andeslint-plugin-react-hooksto catch code quality issues inpages/src/@size-limit/fileto monitor initial bundle size (threshold: 150 kB brotli, current: ~80 kB)webpack.config.js,postcss.config.js,tailwind.config.js→.cjsto support"type": "module"in package.json (required for ESLint flat config ESM imports)no-useless-escapewarnings and 1no-useless-assignmenterror in existing source filespages-ci.ymlto run lint before typecheck and size check after buildCI Pipeline (updated)
Test plan
npm run lintpasses (0 errors, 2 warnings)npm run typecheckpassesnpm run buildsucceedsnpm run sizepasses (80 kB < 150 kB limit)