Skip to content

fix(pages): add dedicated /features route with correct active-tab highlighting #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhengfeng101 merged 3 commits into from
Jul 28, 2026
+25 −2
Merged

fix(pages): add dedicated /features route with correct active-tab highlighting #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3debe92
fix: add dedicated /features route to distinguish from home page
varunsahni18 Jul 28, 2026
c9c7b5a
fix: use dedicated FeaturesRoutePage for /features route
varunsahni18 Jul 28, 2026
4a775d6
chore: retrigger CLA check
varunsahni18 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pages/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import LandingPage from './components/LandingPage';
import ErrorBoundary from './components/ErrorBoundary';
import { useTranslation } from './i18n';
import FeaturesPage from './pages/FeaturesPage';
import FeaturesRoutePage from './pages/FeaturesRoutePage';

const BenchmarkPage = React.lazy(() => import(/* webpackChunkName: "benchmark-page" */ './pages/BenchmarkPage'));
const QuickStartPage = React.lazy(() => import(/* webpackChunkName: "quickstart-page" */ './pages/QuickStartPage'));
Expand Down Expand Up @@ -74,6 +75,7 @@ const App: React.FC = () => {
<Suspense fallback={<div style={{ minHeight: '100vh', background: '#000000' }} />}>
<Routes>
<Route path="/" element={<LandingPage><FeaturesPage /></LandingPage>} />
<Route path="/features" element={<LandingPage><FeaturesRoutePage /></LandingPage>} />
<Route path="/benchmark" element={<LandingPage><BenchmarkPage /></LandingPage>} />
<Route path="/quickstart" element={<LandingPage><QuickStartPage /></LandingPage>} />
<Route path="/docs" element={<DocsPage />} />
Expand Down
6 changes: 4 additions & 2 deletions pages/src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const LANG_OPTIONS: { value: Language; label: string }[] = [
];

const navTabs = [
{ path: '/', labelKey: 'navbar.features' },
{ path: '/features', labelKey: 'navbar.features' },
{ path: '/benchmark', labelKey: 'navbar.benchmark' },
{ path: '/quickstart', labelKey: 'navbar.quickstart' },
{ path: '/docs', labelKey: 'navbar.docs' },
Expand Down Expand Up @@ -80,7 +80,9 @@ const Navbar: React.FC = () => {
{!isMobile && (
<div style={{ display: 'flex', alignItems: 'center', gap: 4 }}>
{navTabs.map((tab) => {
const isActive = tab.path === '/' ? currentPath === '/' : currentPath.startsWith(tab.path);
const isActive = tab.path === '/features'
? (currentPath === '/' || currentPath.startsWith('/features'))
: currentPath.startsWith(tab.path);
return (
<button
key={tab.path}
Expand Down
19 changes: 19 additions & 0 deletions pages/src/pages/FeaturesRoutePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import React from 'react';
import FeaturesSection from '../components/FeaturesSection';
import Footer from '../components/Footer';
import FadeInSection from '../components/FadeInSection';

const FeaturesRoutePage: React.FC = () => {
return (
<div style={{ paddingTop: 72 }}>
<FadeInSection>
<FeaturesSection />
</FadeInSection>
<FadeInSection>
<Footer />
</FadeInSection>
</div>
);
};

export default FeaturesRoutePage;
Loading