fix(vscode): pin linkify-it below v6 to fix vsce package failure - #545
Merged
Conversation
linkify-it v6 switched to named exports, breaking markdown-it's default-import usage inside vsce (`LinkifyIt is not a constructor`). Pin the resolution to `>=5.0.2 <6` so `yarn package` succeeds. Also bumps extension version to 0.1.2.
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkify-itresolution to>=5.0.2 <6to avoid the breaking ESM named-export change in v6ERROR LinkifyIt is not a constructorwhen runningvsce packageContext
linkify-itv6 switched from a default export to named exports ({ LinkifyIt }). Themarkdown-itlibrary bundled in@vscode/vscestill callsnew LinkifyIt()via the default import, causing the packaging step to fail after README markdown processing.Test plan
corepack yarn packagesucceeds and produces a valid.vsix