Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"js-yaml": ">=5.2.2",
"minimatch": "^9.0.7",
"@typescript-eslint/typescript-estree/minimatch": "^9.0.7",
"brace-expansion": ">=2.1.2 <3",
"brace-expansion": "^5.0.8",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential compatibility issue: This changes the brace-expansion resolution from >=2.1.2 <3 (v2.x) to ^5.0.8 (v5.x), which is a major version jump. Key consumers like minimatch@^9.0.7 (also listed in resolutions) depend on brace-expansion@2.x. Forcing v5.x via resolutions may cause runtime breakage because the API between v2 and v5 could be incompatible.

Please verify that all packages depending on brace-expansion (e.g., minimatch, @typescript-eslint/typescript-estree) are compatible with brace-expansion@5.x before merging. If this was intended as a security fix, consider checking whether a patched v2.x release exists instead.

"fast-uri": ">=3.1.4",
"linkify-it": ">=5.0.2"
},
Expand Down
Loading