-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ci: upgrade low-risk GitHub Actions dependencies #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ jobs: | |
| # pull_request_target this checks out the trusted base branch; the | ||
| # composite action performs its own full checkout (fetch-depth: 0) later. | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Potential issue: If the workflow runs with a non-existent action version tag, it will fail immediately. Please verify that each referenced version tag actually exists in the respective action repository before merging. |
||
|
|
||
| - name: Trust workspace | ||
| run: git config --global --replace-all safe.directory '*' | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -29,7 +29,7 @@ jobs: | |||||||||||||||||
| - goos: windows | ||||||||||||||||||
| goarch: arm64 | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||||
| - uses: actions/checkout@v7 | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Trust workspace | ||||||||||||||||||
| run: git config --global --replace-all safe.directory '*' | ||||||||||||||||||
|
Comment on lines
+32
to
35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Non-existent action version. Please revert to Suggestion:
Suggested change
|
||||||||||||||||||
|
|
@@ -70,7 +70,7 @@ jobs: | |||||||||||||||||
| - name: Install git | ||||||||||||||||||
| run: apt-get update && apt-get install -y git | ||||||||||||||||||
|
|
||||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||||
| - uses: actions/checkout@v7 | ||||||||||||||||||
| with: | ||||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -144,15 +144,15 @@ jobs: | |||||||||||||||||
| run: sha256sum opencodereview-* | sort > sha256sum.txt | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Create GitHub Release | ||||||||||||||||||
| uses: softprops/action-gh-release@v2 | ||||||||||||||||||
| uses: softprops/action-gh-release@v3 | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Non-existent action version. Suggestion:
Suggested change
|
||||||||||||||||||
| with: | ||||||||||||||||||
| body: ${{ steps.notes.outputs.body }} | ||||||||||||||||||
| files: | | ||||||||||||||||||
| opencodereview-* | ||||||||||||||||||
| sha256sum.txt | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Attest release artifacts | ||||||||||||||||||
| uses: actions/attest-build-provenance@v2 | ||||||||||||||||||
| uses: actions/attest-build-provenance@v4 | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Non-existent action version. Suggestion:
Suggested change
|
||||||||||||||||||
| with: | ||||||||||||||||||
| subject-path: | | ||||||||||||||||||
| opencodereview-* | ||||||||||||||||||
|
|
@@ -167,7 +167,7 @@ jobs: | |||||||||||||||||
| permissions: | ||||||||||||||||||
| contents: read | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - uses: actions/checkout@v4 | ||||||||||||||||||
| - uses: actions/checkout@v7 | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Trust workspace | ||||||||||||||||||
| run: git config --global --replace-all safe.directory '*' | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential issue: Non-existent action version.
actions/checkout@v7does not appear to be a valid release. The latest known major version isv4. Using a non-existent version tag will cause all workflow runs to fail immediately at the checkout step.If a newer version has indeed been released, please verify the exact tag on the actions/checkout releases page before merging. Additionally, per security best practices, consider pinning third-party actions to a full commit SHA rather than a mutable tag to prevent potential tag-hijacking attacks.