Skip to content

Commit

Permalink
fix:Use the article an before instance (#11759)
Browse files Browse the repository at this point in the history
* fix:Use the article an before instance

* fix:The modal verb 'will' requires the verb's base form.
  • Loading branch information
publicize-y authored Feb 27, 2024
1 parent 7f4c7f8 commit a275356
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
* [#175] Support deregistering instance automatically.
* [#176] Naming client query instance method should bypass local cache at client start.
* [#177] Console supports registering new empty service and delete empty service.
* [#181] NPE when adding a instance if no leader in the raft cluster.
* [#181] NPE when adding an instance if no leader in the raft cluster.
* [#193] Configure host domain name cause nacos server cluster is unavailable.
* [#209] Disable service and cluster level customization in client registerInstance method.
* [#214] Please support Java 11.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private String[] generateIpAndPort(String ip) {
/**
* Generate response ips.
*
* @param instanceList a instance set will generate string response to client.
* @param instanceList an instance set will generate string response to client.
* @return the result of response to client
*/
public String generateResponseIps(List<com.alibaba.nacos.api.naming.pojo.Instance> instanceList) {
Expand All @@ -113,7 +113,7 @@ public String generateResponseIps(List<com.alibaba.nacos.api.naming.pojo.Instanc
/**
* Generate nacos service name.
*
* @param rawServiceName the raw service name will not contains the {@link Constants#DEFAULT_GROUP}.
* @param rawServiceName the raw service name will not contain the {@link Constants#DEFAULT_GROUP}.
* @return the nacos service name
*/
public String generateNacosServiceName(String rawServiceName) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
public interface NamingService {

/**
* register a instance to service.
* register an instance to service.
*
* @param serviceName name of service
* @param ip instance ip
Expand All @@ -43,7 +43,7 @@ public interface NamingService {
void registerInstance(String serviceName, String ip, int port) throws NacosException;

/**
* register a instance to service.
* register an instance to service.
*
* @param serviceName name of service
* @param groupName group of service
Expand All @@ -54,7 +54,7 @@ public interface NamingService {
void registerInstance(String serviceName, String groupName, String ip, int port) throws NacosException;

/**
* register a instance to service with specified cluster name.
* register an instance to service with specified cluster name.
*
* @param serviceName name of service
* @param ip instance ip
Expand All @@ -65,7 +65,7 @@ public interface NamingService {
void registerInstance(String serviceName, String ip, int port, String clusterName) throws NacosException;

/**
* register a instance to service with specified cluster name.
* register an instance to service with specified cluster name.
*
* @param serviceName name of service
* @param groupName group of service
Expand All @@ -78,7 +78,7 @@ void registerInstance(String serviceName, String groupName, String ip, int port,
throws NacosException;

/**
* register a instance to service with specified instance properties.
* register an instance to service with specified instance properties.
*
* @param serviceName name of service
* @param instance instance to register
Expand All @@ -87,7 +87,7 @@ void registerInstance(String serviceName, String groupName, String ip, int port,
void registerInstance(String serviceName, Instance instance) throws NacosException;

/**
* register a instance to service with specified instance properties.
* register an instance to service with specified instance properties.
*
* @param serviceName name of service
* @param groupName group of service
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static None createNoneHealthChecker() {
}

/**
* Deserialize and create a instance of health checker.
* Deserialize and create an instance of health checker.
*
* @param jsonString json string of health checker
* @return new instance
Expand All @@ -83,7 +83,7 @@ public static AbstractHealthChecker deserialize(String jsonString) {
}

/**
* Serialize a instance of health checker to json.
* Serialize an instance of health checker to json.
*
* @param healthChecker health checker instance
* @return son string after serializing
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
public interface NamingClientProxy extends Closeable {

/**
* Register a instance to service with specified instance properties.
* Register an instance to service with specified instance properties.
*
* @param serviceName name of service
* @param groupName group of service
Expand Down

1 comment on commit a275356

@dogyneighbour
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost.49152
how to reading tcp 4/6 local host

Please sign in to comment.