-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
* fix some translation issues * fix some translation issues
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,42 +17,42 @@ Nacos welcome new participants of any role, including user, contributor, committ | |
 | ||
|
||
|
||
We encourage new comers actively join in Nacos projects and involving from user role to committer role, and even PMC role. In order to accomplish this, new comers needs to actively contribute in Nacos project. The following paragraph introduce how to contribute in Nacos way. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ritikdata
|
||
We encourage newcomers actively joining in Nacos projects and involving from user roles to committer roles, and even PMC roles. In order to accomplish this, new comers needs to actively contribute in Nacos project. The following paragraph introduce how to contribute in Nacos way. | ||
|
||
#### Open / pickup an issue for preparation | ||
|
||
If you find a typo in document, find a bug in code, or want new features, or want to give suggestions, you can [open an issue on GitHub](https://github.com/alibaba/Nacos/issues/new) to report it. | ||
This comment has been minimized.
Sorry, something went wrong. |
||
If you find a typo in a document, find a bug in code or want new features, or want to give suggestions, you can [open an issue on GitHub](https://github.com/alibaba/Nacos/issues/new) to report it. | ||
|
||
If you just want to contribute directly you can choose the issue below. | ||
|
||
- [Contribution Welcome](https://github.com/alibaba/nacos/labels/contribution%20welcome): Heavily needed issue, but currently short of hand. | ||
|
||
- [good first issue](https://github.com/alibaba/nacos/labels/good%20first%20issue): Good for newcomers, new comer can pickup one for warm-up. | ||
This comment has been minimized.
Sorry, something went wrong. |
||
- [good first issue](https://github.com/alibaba/nacos/labels/good%20first%20issue): Good for newcomers, newcomers can pick up one for warm-up. | ||
|
||
|
||
We strongly value documentation and integration with other projects such as Spring Cloud, Kubernetes, Dubbo, etc. We are very glad to work on any issue for these aspects. | ||
|
||
Please note that any PR must be associated with a valid issue. Otherwise the PR will be rejected. | ||
This comment has been minimized.
Sorry, something went wrong. |
||
Please note that any PR must be associated with a valid issue. Otherwise, the PR will be rejected. | ||
|
||
#### Begin your contribute | ||
#### Begin your contribution | ||
|
||
Now if you want to contribute, please create a new pull request. | ||
|
||
We use the `develop` branch as the development branch, which indicates that this is a unstable branch. | ||
We use the `develop` branch as the development branch, which indicates that this is an unstable branch. | ||
|
||
Further more, our branching model complies to [https://nvie.com/posts/a-successful-git-branching-model/](https://nvie.com/posts/a-successful-git-branching-model/). We strongly suggest new comers walk through the above article before creating PR. | ||
This comment has been minimized.
Sorry, something went wrong. |
||
Furthermore, our branching model complies with [https://nvie.com/posts/a-successful-git-branching-model/](https://nvie.com/posts/a-successful-git-branching-model/). We strongly suggest new comers walk through the above article before creating PR. | ||
|
||
Now, if you are ready to create PR, here is the workflow for contributors: | ||
|
||
1. Fork to your own | ||
|
||
2. Clone fork to local repository | ||
This comment has been minimized.
Sorry, something went wrong. |
||
2. Clone fork to a local repository | ||
|
||
3. Create a new branch and work on it | ||
|
||
4. Keep your branch in sync | ||
|
||
5. Commit your changes (make sure your commit message concise) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
5. Commit your changes (make sure your commit message is concise) | ||
|
||
6. Push your commits to your forked repository | ||
|
||
|
@@ -73,7 +73,7 @@ When creating pull request: | |
|
||
6. After creating a PR, one or more reviewers will be assigned to the pull request. | ||
|
||
7. Before merging a PR, squash any fix review feedback, typo, merged, and rebased sorts of commits. The final commit message should be clear and concise. | ||
7. Before merging a PR, squash any fix review feedback, typo, merged and rebased sorts of commits. The final commit message should be clear and concise. | ||
|
||
|
||
If your PR contains large changes, e.g. component refactor or new components, please write detailed documents about its design and usage. | ||
|
@@ -86,7 +86,7 @@ Some principles: | |
|
||
- Readability - Important code should be well-documented. API should have Javadoc. Code style should be complied with the existing one. | ||
|
||
- Elegance: New functions, classes or components should be well designed. | ||
- Elegance: New functions, classes or components should be well-designed. | ||
|
||
- Testability - 80% of the new code should be covered by unit test cases. | ||
|
||
|
@@ -106,18 +106,18 @@ Generally speaking, contribute 8 non-trivial patches and get at least three diff | |
- ability to write good code (last but certainly not least) | ||
|
||
|
||
A current committer nominates you by slacking the team on the Nacos issue with label "nomination" | ||
A current committer nominates you by slacking the team on the Nacos issue with the label "nomination" | ||
|
||
- your first and last name | ||
|
||
- a link to your Git profile | ||
|
||
- an explanation of why you should be a committer, | ||
|
||
- Elaborate the top 3 PR and the associated issues the nominator has worked with you that can demonstrate your ability. | ||
- Elaborate on the top 3 PR and the associated issues the nominator has worked with you that can demonstrate your ability. | ||
|
||
|
||
Two other committer need to second your nomination. If no one objects in 5 working days (China), you're a committer. If anyone objects or wants more information, the committers discuss and usually come to a consensus (within the 5 working days). If issues cannot be resolved, there's a vote among current committers. | ||
Two other committers need to second your nomination. If no one objects in 5 working days (China), you're a committer. If anyone objects or wants more information, the committers discuss and usually come to a consensus (within the 5 working days). If issues cannot be resolved, there's a vote among current committers. | ||
|
||
 | ||
|
||
|
1 comment
on commit 86193ec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..
u will come b/w t and a