Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ignore the PushRequest to the xDS server #888

Closed

Conversation

alexzzh
Copy link
Collaborator

@alexzzh alexzzh commented Mar 27, 2024

Ⅰ. Describe what this PR did

  • 可以控制"控制平面"是否能主动向"数据平面"推送资源
    • 默认允许推送,不改变原来的行为
  • 在 higress controller debug界面提供开关,接口功能说明如下图

4781711533812_ pic

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

  • step 1: 配置ingress、wasmplugin、 全局配置资源前点击 /debug/ignorePushRequest,禁止推送
  • step 2: 配置ingress、wasmplugin、 全局配置资源
  • step 3: 查看数据平面相关配置没有生效或者higress controller没有出现推送日志
  • step 4: 点击 /debug/ignorePushRequest?disable=true 或者 /debug/ignorePushRequest?disable=true&push=true接口,允许推送,两者的区别是后者允许推送的同时强制推送一次数据
  • step 5: 查看数据平面相关配置已经生效或者higress controller出现推送日志,日志内容如下:
2024-03-27T10:13:32.406062Z	info	ads	full push happen, reason:[force push after disable ignorePushRequest]
2024-03-27T10:13:32.510065Z	info	ads	Push debounce stable[2] 1: 101.962084ms since last change, 101.961875ms since last push, full=true
2024-03-27T10:13:32.510486Z	info	ingress	resource type networking.istio.io/v1alpha3/ServiceEntry, configs number 1
2024-03-27T10:13:32.510530Z	info	ingress	resource type networking.istio.io/v1alpha3/VirtualService, configs number 1
2024-03-27T10:13:32.510593Z	info	ingress	Found 0 number of basic auth
2024-03-27T10:13:32.510621Z	info	ingress	Found 0 number of envoyFilters
2024-03-27T10:13:32.510671Z	info	ingress	resource type networking.istio.io/v1alpha3/DestinationRule, configs number 1
2024-03-27T10:13:32.510730Z	info	ingress	resource type extensions.istio.io/v1alpha1/WasmPlugin, configs number 1
2024-03-27T10:13:32.510745Z	info	ingress	controller tracing ConstructEnvoyFilters
2024-03-27T10:13:32.510749Z	info	ingress	controller gzip ConstructEnvoyFilters
2024-03-27T10:13:32.511198Z	info	ingress	controller global-option ConstructEnvoyFilters
. . .

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants