Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add try-paths plugin #876

Closed
wants to merge 10 commits into from
Closed

add try-paths plugin #876

wants to merge 10 commits into from

Conversation

haifzhu
Copy link
Collaborator

@haifzhu haifzhu commented Mar 19, 2024

Ⅰ. Describe what this PR did

add try-paths wasm go plugin to implement try_files function of nginx。

Ⅱ. Does this pull request fix one issue?

Fix the issue: Add support of try_files usage #840

Ⅲ. Why don't you add test cases (unit test/integration test)?

No needed

Ⅳ. Describe how to verify it

enable the plugin on the route, and check its retry function on envoy log.

Ⅴ. Special notes for reviews

no

@johnlanni
Copy link
Collaborator

@haifzhu Please add an e2e test for it.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024

CLA assistant check
All committers have signed the CLA.

@johnlanni
Copy link
Collaborator

@haifzhu Your PR includes commits from other people.

@haifzhu haifzhu closed this Apr 1, 2024
@haifzhu
Copy link
Collaborator Author

haifzhu commented Apr 1, 2024

as the pull request out of date for long time, repull again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants