Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add try-paths plugin #874

Closed
wants to merge 2 commits into from
Closed

add try-paths plugin #874

wants to merge 2 commits into from

Conversation

haifzhu
Copy link
Collaborator

@haifzhu haifzhu commented Mar 18, 2024

Ⅰ. Describe what this PR did

添加一个try-paths wasm go plugin,实现nginx的try_files功能。

Ⅱ. Does this pull request fix one issue?

解决问题: Add support of try_files usage #840

Ⅲ. Why don't you add test cases (unit test/integration test)?

逻辑比较简单,无需单元测试

Ⅳ. Describe how to verify it

按照正常的插件添加到路由上,查看请求效果

Ⅴ. Special notes for reviews

功能验证是通过的,不过需要注意是否有异常场景没有兼顾到

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ haifzhu
❌ 片风


片风 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@haifzhu
Copy link
Collaborator Author

haifzhu commented Mar 19, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ haifzhu❌ 片风

片风 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@haifzhu haifzhu closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants