Skip to content

fix atomic #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cnangel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix atomic #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions aios/autil/autil/AtomicCounter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ namespace autil {
: "Ir"(i) \
: cl); \
\
return result == 0;
return result < 0;

// operations used in 64bit atomic counter in aarch64 architecture

Expand All @@ -100,8 +100,8 @@ namespace autil {
" prfm pstl1strm, %2\n" \
"1: ldxr %x0, %2\n" \
" " #asm_op " %x0, %x0, %x3\n" \
" stxr %x1, %x0, %2\n" \
" cbnz %x1, 1b" \
" stxr %w1, %x0, %2\n" \
" cbnz %w1, 1b" \
: "=&r"(result), "=&r"(tmp), "+Q"(_counter) \
: "Ir"(i));

Expand All @@ -114,8 +114,8 @@ namespace autil {
" prfm pstl1strm, %2\n" \
"1: ld" #acq "xr %x0, %2\n" \
" " #asm_op " %x0, %x0, %x3\n" \
" st" #rel "xr %x1, %x0, %2\n" \
" cbnz %x1, 1b\n" \
" st" #rel "xr %w1, %x0, %2\n" \
" cbnz %w1, 1b\n" \
" " #mb \
: "=&r"(result), "=&r"(tmp), "+Q"(_counter) \
: "Ir"(i) \
Expand All @@ -132,8 +132,8 @@ namespace autil {
" prfm pstl1strm, %2\n" \
"1: ld" #acq "xr %x0, %2\n" \
" " #asm_op " %x0, %x0, %x3\n" \
" st" #rel "xr %x1, %x0, %2\n" \
" cbnz %x1, 1b\n" \
" st" #rel "xr %w1, %x0, %2\n" \
" cbnz %w1, 1b\n" \
" " #mb \
: "=&r"(result), "=&r"(tmp), "+Q"(_counter) \
: "Ir"(i) \
Expand All @@ -150,8 +150,8 @@ namespace autil {
" prfm pstl1strm, %2\n" \
"1: ld" #acq "xr %x0, %2\n" \
" " #asm_op " %x0, %x0, %x3\n" \
" st" #rel "xr %x1, %x0, %2\n" \
" cbnz %x1, 1b\n" \
" st" #rel "xr %w1, %x0, %2\n" \
" cbnz %w1, 1b\n" \
" " #mb \
: "=&r"(result), "=&r"(tmp), "+Q"(_counter) \
: "Ir"(i) \
Expand Down