Skip to content

fix(task-executor): task-executor sidecar mode env issue #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pangjiping merged 2 commits into from
Jan 12, 2026
Merged

fix(task-executor): task-executor sidecar mode env issue #82

Pangjiping merged 2 commits into from
Jan 12, 2026
+134 −4

Conversation

@fengcone
Copy link
Collaborator

@fengcone fengcone commented Jan 9, 2026

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

Pangjiping
Pangjiping previously approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengcone fengcone requested a review from Pangjiping January 12, 2026 06:17
Pangjiping
Pangjiping approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pangjiping Pangjiping merged commit 2bd9e2a into alibaba:main Jan 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Generalwin Generalwin Generalwin approved these changes

@Pangjiping Pangjiping Pangjiping approved these changes

@Spground Spground Awaiting requested review from Spground Spground is a code owner

@kevinlynx kevinlynx Awaiting requested review from kevinlynx kevinlynx is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fengcone @Generalwin @Pangjiping