feat(server): support create sandbox from pool #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalwin
force-pushed
the
k8s-pool
branch
2 times, most recently
from
2677a3a to
7f0d3a5
Compare
Generalwin
requested review from
Pangjiping,
Spground,
fengcone,
hittyt,
jwx0925,
kevinlynx and
ninan-nn
as code owners
Collaborator
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f0d3a5280
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pangjiping
reviewed
Jan 12, 2026
| ) | ||
|
|
||
| sandbox = await Sandbox.create( | ||
| image, # TODO: no need to specify image |
Collaborator
There was a problem hiding this comment.
Could you clarify what this TODO means?
| mkdir -p /opt/opensandbox/execd && | ||
| cp ./execd /opt/opensandbox/execd/execd && | ||
| chmod +x /opt/opensandbox/execd/execd && | ||
| cat > /opt/opensandbox/execd/bootstrap.sh << 'BOOTSTRAP_EOF' |
Collaborator
There was a problem hiding this comment.
exed image has a bootstrap.sh script under /
Pangjiping
requested changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support creating sandboxes from existing resource pools via poolRef in extensions field
When poolRef is provided, the system uses pre-warmed pods from the pool instead of creating new ones
Only entrypoint and env can be customized in pool mode; image and resources are predefined by the pool
Implemented taskTemplate generation that dynamically injects environment variables
Environment variables are written to .env file at runtime using shell commands
User process runs in background mode to keep container alive
Testing
Breaking Changes
Checklist