Skip to content

Use pattern matching in tree traversal (Rust) #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Use pattern matching in tree traversal (Rust) #573

merged 2 commits into from
Jan 7, 2019

Conversation

barskern
Copy link
Contributor

@barskern barskern commented Jan 7, 2019

Destructuring an array using pattern matching makes the code more readable. This is a more idiomatic solution in Rust.

This PR also adds a bit of space in the example to make it more readable in accordance with the code style for the AAA.

@leios
Copy link
Member

leios commented Jan 7, 2019

Thanks! We'll take a look at these soon.

@Gathros Gathros added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jan 7, 2019
@leios leios requested a review from Gathros January 7, 2019 20:43
@nic-hartley
Copy link
Contributor

rust-lang/rust#23121

This feature is experimental and undergoing changes soon, let's maybe not rely on it?

@Gathros Gathros merged commit 65fa1dd into algorithm-archivists:master Jan 7, 2019
@Gathros
Copy link
Contributor

Gathros commented Jan 7, 2019

Great timing @nic-hartley. Make an new pull request on the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants