Canonical Messagepack: add missing constraints#100
Closed
iansuvak wants to merge 1 commit intoalgorandfoundation:masterfrom
Closed
Canonical Messagepack: add missing constraints#100iansuvak wants to merge 1 commit intoalgorandfoundation:masterfrom
iansuvak wants to merge 1 commit intoalgorandfoundation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing msgp codegen that would verify message canonicity at unmarshal time I noticed that the spec isn't fully specified. This adds the missing rules.
I've expanded rule 4 to not make it specific to integers but catch all variable length fields but we could break it out further if preferred.