feat: deterministic resource population #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-p
commented
Oct 1, 2025
| } | ||
|
|
||
| const allResources = [] | ||
| for (let i = 0; i < 100; i++) { |
There was a problem hiding this comment.
100 iterations takes ~800ms on my machine. I think it's good enough to feel confident that it is indeed deterministic
There was a problem hiding this comment.
Pull Request Overview
This PR ensures deterministic resource population for AlgoKit when populating app call resources. It addresses non-deterministic resource ordering that was causing edge-case failures by implementing a consistent sorting algorithm for all resource types.
- Implements deterministic sorting for all resource arrays returned by
groupResponse.unnamedResourcesAccessed - Adds comprehensive tests to verify deterministic behavior across 100 iterations
- Updates corresponding artifact files to reflect the new smart contract functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/example-contracts/resource-packer/resource-packer.algo.ts | Adds new methods and properties to test deterministic resource population |
| tests/example-contracts/resource-packer/artifacts/ResourcePackerv9.arc32.json | Updates compiled contract artifacts with new methods and updated bytecode |
| tests/example-contracts/resource-packer/artifacts/ResourcePackerv8.arc32.json | Updates bytecode to reflect changes in the contract compilation |
| tests/example-contracts/resource-packer/artifacts/InnerBoxApp.arc32.json | Updates compiled bytecode for inner box application |
| tests/example-contracts/resource-packer/artifacts/ExternalApp.arc32.json | Updates compiled bytecode for external application |
| src/transaction/transaction.ts | Implements deterministic sorting logic for all resource types |
| src/transaction/transaction.spec.ts | Adds test to verify deterministic resource ordering across multiple iterations |
| docs/code/modules/index.md | Updates line numbers in documentation due to code changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return compare(aStr, bStr) | ||
| }) | ||
| sortedResources.assetHoldings?.sort((a, b) => { | ||
| const aStr = `${a.asset}-${b.account}` |
There was a problem hiding this comment.
Suggested change
| const aStr = `${a.asset}-${b.account}` | |
| const aStr = `${a.asset}-${a.account}` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that resource population is deterministic. It should be noted that there is no way to guarantee that the algorithm we have is the most efficient and what works best for one group may not be best for another. For now, having determinism is a good starting point to eliminate edge-case failures. In the future we could potentially add retry mechanism with different ordering.