Add Ledger X Support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeldovich
approved these changes
Jan 6, 2020
gmalouf
pushed a commit
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Ledger Nano X using its UI library (with built-in paging support!). Previously I modified the SDK a bit in order to support page skipping functionality when displaying irrelevant transaction fields, but in this PR I pulled out the relevant macros from the SDK and modified them here (see
ALGO_UX_STEP_NOCB_INIT).Bluetooth functionality should work.
This should still build successfully on the Nano S as well.
One not-great thing about this PR is that because the UI library is different, there's some duplicated code to set up the UI flow for each device.
This PR does not include a fix for the bug in #6