Skip to content

Fix Challenge 4 🦞 #50

Open
kiliancm94 wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
kiliancm94:main
Open

Fix Challenge 4 🦞 #50
kiliancm94 wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
kiliancm94:main

Conversation

@kiliancm94
Copy link
Copy Markdown

Fix the Bug Submission Pull Request

What was the bug?

When adding atomic transactions the signer parameter was sent as an Account when it needs a TransactionSigner.

How did you fix the bug?

By reading the documentation I have found a method to get the Transaction Signer from the Account.
https://github.com/algorandfoundation/algokit-utils-ts/blob/main/docs/capabilities/transaction.md#signing
Therefore, I have updated the code to fix the issue.

const senderTransactionSigner = algokit.getSenderTransactionSigner(sender)

const atc = new algosdk.AtomicTransactionComposer()
atc.addTransaction({txn: ptxn1, signer: senderTransactionSigner})
atc.addTransaction({txn: ptxn2, signer: senderTransactionSigner})

Console Screenshot:

Captura de pantalla 2024-03-29 a las 10 35 42

@iskysun96 iskysun96 added the Approved ✅ Successfully completed the challenge! label Apr 1, 2024
@iskysun96
Copy link
Copy Markdown
Contributor

🎉 Congrats on solving the 4th Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/8x3aqnmh7p2wf25dvmxz7ksvjs3gr02d6648tf31ny90wwtams53jvssjwcj2bgfs7qr425958h3abw83a33t3tdbqb0sjtntmta82r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved ✅ Successfully completed the challenge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants