Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): update docker image #1309

Merged
merged 2 commits into from
Oct 8, 2021
Merged

fix(ci): update docker image #1309

merged 2 commits into from
Oct 8, 2021

Conversation

shortcuts
Copy link
Member

Summary

Fixes Circle CI docker image issue

See https://circleci.com/developer/images/image/cimg/node for more informations

TLDR: This image is designed to supercede the legacy CircleCI Node.js image, circleci/node.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9c7843:

Sandbox Source
javascript-client-app Configuration

Haroenv
Haroenv approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge if ci is green :D

DevinCodes
DevinCodes approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@DevinCodes DevinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the green CI indeed 😄

@shortcuts
Copy link
Member Author

This issue has been present in the past, I think it should be fixed in a future PR @Haroenv @DevinCodes, wdyt? https://app.circleci.com/pipelines/github/algolia/algoliasearch-client-javascript/1451/workflows/0c58820c-2ade-48ed-818d-5a730e45be97/jobs/11010

@Haroenv
Copy link
Contributor

Haroenv commented Oct 7, 2021

Ok for me to fix this test separately @shortcuts

@shortcuts shortcuts merged commit 6223bf6 into master Oct 8, 2021
@shortcuts shortcuts deleted the fix/ci branch October 8, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevinCodes DevinCodes DevinCodes approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @Haroenv @DevinCodes