Skip to content

Issue 639 ✨ feature design hide other pairs and cancel all orders buttons #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

IYTEC
Copy link
Contributor

@IYTEC IYTEC commented Aug 5, 2022

ℹ Overview

Update cancel button in open order.

📝 Related Issues

🔐 Acceptance:

  • yarn test passes
  • Uses Unicode conventional commits gitmoji

@IYTEC IYTEC requested review from stephclarkga and atrefonas August 5, 2022 09:00
@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
algodex-react-dev ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 9:00AM (UTC)

Copy link
Contributor

@atrefonas atrefonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Cancel all orders needs to be a button you can press, not just a header. Otherwise, better to hide it for now.
  2. This PR should be branched off of next3 not development
  3. It should look like Steph's screenshot:
    image
    🎨 Design: Hide Other Pairs and Cancel All Orders buttons #639

@atrefonas
Copy link
Contributor

Also, this needs the filtering features as seen in this issue: #639 screenshots by @stephclarkga

@IYTEC
Copy link
Contributor Author

IYTEC commented Sep 7, 2022

Yes. that's why I am still leaving it open, till we're done with Merging next3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants