Added customizable options to the notification#6
Open
JRomainG wants to merge 2 commits intoalexleutgoeb:masterfrom
Open
Added customizable options to the notification#6JRomainG wants to merge 2 commits intoalexleutgoeb:masterfrom
JRomainG wants to merge 2 commits intoalexleutgoeb:masterfrom
Conversation
• Can provide custom background color to the view • Can provide custom duration • View stays in parent view's bounds • Views are automatically re-positioned when interface orientation changes • Made the text bigger (auto-adjusts font size to fit) • Label can have up to 3 lines • Added static values to make the code easier to understand/customize
Duration used was the wrong view’s duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these features:
• Can provide a custom background color to the view
• Can provide a custom duration
• View stays in parent view's bounds
• Views are automatically re-positioned when the interface orientation changes
• Made the text bigger (and updated the auto-adjusts font size)
• Label can have up to 3 lines
• Added static values to make the code easier to understand/customize