Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Update RoundcubeAutoLogin.php#13

Open
geek3000 wants to merge 2 commits intoalexjeen:masterfrom
geek3000:patch-1
Open

Update RoundcubeAutoLogin.php#13
geek3000 wants to merge 2 commits intoalexjeen:masterfrom
geek3000:patch-1

Conversation

@geek3000
Copy link

@geek3000 geek3000 commented Apr 2, 2022

update Set-Cookies to set-cookies regex

update Set-Cookies to set-cookies regex
@section117
Copy link

update Set-Cookies to set-cookies regex works. I was having the same issue, tried this, and it works.
Thank you @geek3000

tpo added a commit to sourcepole/roundcube-login-check that referenced this pull request Apr 18, 2022
@tpo
Copy link

tpo commented Apr 18, 2022

@geek3000 :

  • your pull request includes unrelated stuff (setting time zone to Africa, setting the URL to webmail.kmail.africa ...). Would be nice if you could update your patch to only include the relevant setting.
  • as described here Is the project still usable? #11 (comment) older RoundCubes apparently used upper case "Set-Cookes" and newer ones use lower case "set-cookes". If you'd use the /i flag as described in the linked post then RoundcubeAutoLogin would support both old and new RoundCubes. Would also be nice to include that in your pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants