Skip to content

Test local debug #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Test local debug #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ccd1562
Update app.py
alexcoderabbitai Nov 26, 2024
0623380
Update app.py
alexcoderabbitai Nov 29, 2024
4721e9e
add more to black
alexcoderabbitai Nov 30, 2024
f45547f
Update app.py
alexcoderabbitai Dec 2, 2024
6e704dc
adding a long gh action
alexcoderabbitai Jul 11, 2025
ee5945e
change timeout_ms
alexcoderabbitai Jul 11, 2025
adc2318
wait longer
alexcoderabbitai Jul 11, 2025
e01d293
fix typo
alexcoderabbitai Jul 11, 2025
b798f41
test with sleep
alexcoderabbitai Jul 11, 2025
22a22ac
fix it so it takes 4 min
alexcoderabbitai Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .coderabbit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
reviews:
tools:
github-checks:
enabled: true
timeout_ms: 900000
28 changes: 28 additions & 0 deletions .github/workflows/comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Auto Comment on PR

on:
pull_request:
types: [*] # Triggers on all pull request events
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix invalid YAML syntax for pull request event types.

The wildcard * in YAML arrays must be quoted to be valid.

Apply this diff to fix the YAML syntax:

-    types: [*]  # Triggers on all pull request events
+    types: ["*"]  # Triggers on all pull request events
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
types: [*] # Triggers on all pull request events
types: ["*"] # Triggers on all pull request events
🤖 Prompt for AI Agents 
In .github/workflows/comment.yml at line 5, the YAML syntax for the pull request
event types uses an unquoted wildcard `*`, which is invalid. Fix this by
enclosing the asterisk in quotes, changing `types: [*]` to `types: ["*"]` to
ensure proper YAML parsing.

# pull_request:
# types: [opened]

workflow_dispatch:

jobs:
comment:
runs-on: ubuntu-latest
steps:
# - name: trigger pr
# uses: peter-evans/create-or-update-comment@v4
# with:
# issue-number: ${{ github.event.pull_request.number }}
# body: |
# @coderabbitai full review
# - name: trigger pr
# uses: peter-evans/create-or-update-comment@v4
# with:
# issue-number: ${{ github.event.pull_request.number }}
# body: |
# @coderabbitai sing me a song
- name: Wait 300 sec for timeout
run: sleep 300
Comment on lines +27 to +28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unnecessary sleep command or implement actual functionality.

The workflow currently only sleeps for 5 minutes without providing any value, which wastes CI resources.

Consider either:

  1. Removing this workflow entirely if not needed
  2. Uncommenting and implementing the actual comment functionality
  3. Replacing the sleep with meaningful automation

If this is temporary debugging code, consider removing it:

-      - name: Wait 300 sec for timeout
-        run: sleep 300
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Wait 300 sec for timeout
run: sleep 300
🤖 Prompt for AI Agents 
In .github/workflows/comment.yml at lines 27 to 28, the workflow contains a
sleep command that pauses execution for 300 seconds without adding value,
wasting CI resources. To fix this, either remove the sleep command entirely if
it is unnecessary, replace it with meaningful automation that serves a purpose
in the workflow, or uncomment and implement the intended comment functionality
if that was the original goal. If this sleep was added for temporary debugging,
remove it before finalizing the workflow.

2 changes: 1 addition & 1 deletion .github/workflows/linters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
run: pip install black

- name: Run black check
run: black --check .
run: sleep 200 && black --diff . && black --check .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unnecessary delays and optimize Black formatting step.

The 200-second sleep and --diff output add unnecessary time and verbosity to the CI pipeline without providing value in production.

Apply this diff to optimize the workflow:

-        run: sleep 200 && black --diff . && black --check .
+        run: black --check .
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: sleep 200 && black --diff . && black --check .
run: black --check .
🤖 Prompt for AI Agents 
In .github/workflows/linters.yaml at line 39, remove the "sleep 200" delay and
the "--diff" option from the Black formatting command to speed up the CI
pipeline and reduce unnecessary output. Change the command to just run "black
--check ." without any delay or diff output.

6 changes: 5 additions & 1 deletion app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
from routes.wow import wow_bp
from utils.security import add_security_headers, return_safe_html

a=1



# Enable Datadog tracing
patch_all()
profiler = Profiler()
Expand Down Expand Up @@ -920,7 +924,7 @@ def ffxiv_scrip_exchange():


if __name__ == "__main__":
app.run(host="0.0.0.0")
app.run(host="0.0.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix syntax error - missing closing parenthesis.

The app.run() call is missing its closing parenthesis, which causes a syntax error and prevents the application from running.

Apply this diff to fix the syntax error:

-    app.run(host="0.0.0.0"
+    app.run(host="0.0.0.0")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
app.run(host="0.0.0.0"
app.run(host="0.0.0.0")
🤖 Prompt for AI Agents 
In app.py at line 927, the app.run() call is missing a closing parenthesis,
causing a syntax error. Add the missing closing parenthesis at the end of the
app.run() call to fix the syntax error and allow the application to run
properly.


# for testing

Expand Down
Loading