Improve performance and decrease memory use #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inData and outData were always being allocated even when one of them was unused. Now they are only allocated if they are actually used. Same thing with the deviceNames array. It makes no sense to allocate it with a capacity of 100. initWithCapacity should only be used when the exact final size of the array is known. Instead, the array should dynamically change its size when new elements are added/removed. dispatch_one is much quicker than @synchronized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inData and outData were always being allocated even when one of
them was unused. Now they are only allocated if they are actually used.
Same thing with the deviceNames array.
It makes no sense to allocate it
with a capacity of 100.
initWithCapacityshould only be used when theexact final size of the array is known. Instead, the array should
dynamically change its size when new elements are added/removed.
And
dispatch_oneis much quicker than@synchronized.